Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pyproject.toml: Work on the readability of ruff settings #1850

Merged
merged 6 commits into from Oct 27, 2023

Conversation

cclauss
Copy link
Contributor

@cclauss cclauss commented Oct 24, 2023

Description

pyproject.toml: Work on the readability of ruff settings

Please include a summary of the change and which issue is fixed. Please also
include relevant motivation and context. Your commit message should include
this information as well.

Fixes # (issue)

Checklist:

  • I have added the relevant tests for this change.
  • I have added an item to the Pending section of docs/changes.rst.

pyproject.toml Outdated Show resolved Hide resolved
pyproject.toml Outdated Show resolved Hide resolved
Copy link
Contributor

@tim-schilling tim-schilling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm in favor of this change. It looks like the major differences are the line-length and complexity.

Copy link
Member

@matthiask matthiask left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I'm a bit indifferent (the previous ordering was based on the order here https://docs.astral.sh/ruff/rules/ , the current ordering is alphabetical according to the short name) but I appreciate your work.

@matthiask matthiask merged commit e1658db into jazzband:main Oct 27, 2023
26 checks passed
@matthiask
Copy link
Member

Thanks!

@cclauss cclauss deleted the patch-1 branch October 27, 2023 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants