Remove obsolete staticfiles check #1894
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tim-schilling
approved these changes
Mar 11, 2024
living180
force-pushed
the
staticfiles_check
branch
from
b6a1349
to
4cd54ab
Compare
The toolbar had a check for misconfigured static files directories. However, Django 4.0 added its own check for this situation. Since the toolbar's minimum supported Django version is now 4.2, the toolbar's check is made redundant by Django's check and can thus be removed.
living180
force-pushed
the
staticfiles_check
branch
from
4cd54ab
to
cc48a14
Compare
|
Should I add that information to the changelog entry? |
|
No, I was just adding it here for future reference. I should have noted that in my message, sorry! |
|
No worries, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The toolbar had a check for misconfigured static files directories. However, Django 4.0 added its own check for this situation. Since the toolbar's minimum supported Django version is now 4.2, the toolbar's check is made redundant by Django's check and can thus be removed.
Checklist:
docs/changes.rst.