First bunch of fixes to make debug-toolbar work with Python 3 #365
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I made these initial fixes to start porting debug-toolbar to Python 3. These are the "easy" ones.
The big problem will be the replace_call decorator from utils.tracking, cause you can no longer get the defining class from method (although you can get its name by qualname). So I'd advise changing the signature of replace_call to replace_call(klass, func), where klass will be the defining class(/module) itself and func will be string name of function. I'll do the work, but I want to make sure you'd accept such a change.
Thanks!