force username to be lowercase #49
Conversation
| pipe.delete(get_username_attempt_cache_key(username)) | ||
| pipe.delete(get_username_blocked_cache_key(username)) | ||
| pipe.delete(get_username_attempt_cache_key(username.lower())) | ||
| pipe.delete(get_username_blocked_cache_key(username.lower())) |
There was a problem hiding this comment.
I wasn't sure why these lines where here twice?
Does it make sense to leave them and then add two more that do the same with the username.lower()?
There was a problem hiding this comment.
Sorry, I didn't see this sooner. I think it makes sense to always store usernames in the same case, lower probably.
We could so add the .lower() inside of the get_username_attempt_cache_key() and get_username_blocked_cache_key() this way we don't have to always pass in a lower case username, and it keep it all in one place.
There was a problem hiding this comment.
hey sorry guy's I guess we all dropped the ball on this one. My apologies for not seeing this sooner as well!
|
Should we close this, it has been open for over a year and a half with no update. |
|
It seems to me like a reasonable use case tough, can grab this, it doesn't look like a big amount of work |
|
@MattBlack85 I agree, thank you! |
|
closing since #90 is replacing this one. Thanks for the help. |
No description provided.