Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: #187 return csv field value in widget #205

Merged
merged 3 commits into from
Jun 13, 2022

Conversation

Dresdn
Copy link
Contributor

@Dresdn Dresdn commented Jun 13, 2022

I'm helping!

Checklist

  • I have double checked that there are no unrelated changes in this pull request (old patches, accidental config files, etc.)
  • I have created at least one test case for the changes I have made
  • I have updated the documentation for the changes I have made
  • I have added my changes to the CHANGELOG.md

Pull Request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

Related issue(s)

Closes #187

Other Information

@codecov
Copy link

codecov bot commented Jun 13, 2022

Codecov Report

Merging #205 (361eebf) into master (04f5fa4) will increase coverage by 2.43%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #205      +/-   ##
==========================================
+ Coverage   87.36%   89.79%   +2.43%     
==========================================
  Files          20       20              
  Lines         736      745       +9     
  Branches      133      134       +1     
==========================================
+ Hits          643      669      +26     
+ Misses         71       52      -19     
- Partials       22       24       +2     
Impacted Files Coverage Δ
eav/forms.py 79.16% <100.00%> (+24.23%) ⬆️
eav/widgets.py 64.00% <100.00%> (+16.94%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 04f5fa4...361eebf. Read the comment docs.

@Dresdn Dresdn changed the title Dresdn/issue 187 fix: #187 return csv field value in widget Jun 13, 2022
@Dresdn Dresdn merged commit b5702fb into jazzband:master Jun 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adding value to attribute throws an exception
1 participant