Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improvements to URL's and Tests #6

Merged
merged 12 commits into from
Aug 22, 2013
Merged

Improvements to URL's and Tests #6

merged 12 commits into from
Aug 22, 2013

Commits on Jul 27, 2013

  1. Regex for youtube now handles more youtube urls correctly 

    - rev bump
    @techdragon
    techdragon committed Jul 27, 2013
    Configuration menu
    Copy the full SHA
    63025f8 View commit details
    Browse the repository at this point in the history

  2. Better youtube detection logic. 

    - rev bump
    @techdragon
    techdragon committed Jul 27, 2013
    Configuration menu
    Copy the full SHA
    bde468d View commit details
    Browse the repository at this point in the history

  3. Fixed regex comparator to use search() not match() so it can match th… 

    …e new youtube detection regex.

- and rev bump
    @techdragon
    techdragon committed Jul 27, 2013
    Configuration menu
    Copy the full SHA
    f8693c3 View commit details
    Browse the repository at this point in the history

Commits on Aug 3, 2013

  1. Merge pull request #1 from yetty/master 

    Merging upstream
    @techdragon
    techdragon committed Aug 3, 2013
    Configuration menu
    Copy the full SHA
    5032e0b View commit details
    Browse the repository at this point in the history

Commits on Aug 22, 2013

  1. Merge commit '0fdc6a3df75813235a4d6beafc250dcb3d3cfabd'

    @techdragon
    techdragon committed Aug 22, 2013
    Configuration menu
    Copy the full SHA
    319f8af View commit details
    Browse the repository at this point in the history

  2. new regexes 

    - updated detection for youtube to detect ok without protocol
- updated detection for vimeo to detect ok without protocol
- updated vimeo video ID finding regex to handle embed video url format 'player.vimeo.com/video/ID'
- updated youtube url to match more of the multiple youtube url formats
    @techdragon
    techdragon committed Aug 22, 2013
    Configuration menu
    Copy the full SHA
    7abfb3e View commit details
    Browse the repository at this point in the history

  3. Merge commit 'ef614d8bf038c4518b6869993e24981b81e67c36'

    @techdragon
    techdragon committed Aug 22, 2013
    Configuration menu
    Copy the full SHA
    5b415c8 View commit details
    Browse the repository at this point in the history

  4. Merge commit '1040bb1a60b796885de5860e254d210fbacbed18'

    @techdragon
    techdragon committed Aug 22, 2013
    Configuration menu
    Copy the full SHA
    1b9db71 View commit details
    Browse the repository at this point in the history

  5. trimming the regex comment out since its superfluous and breaks PEP8

    @techdragon
    techdragon committed Aug 22, 2013
    Configuration menu
    Copy the full SHA
    abc8df0 View commit details
    Browse the repository at this point in the history

  6. Added more test cases to the URLs for both youtube and vimeo

    @techdragon
    techdragon committed Aug 22, 2013
    Configuration menu
    Copy the full SHA
    3f66fc3 View commit details
    Browse the repository at this point in the history

  7. fixed missing commas

    @techdragon
    techdragon committed Aug 22, 2013
    Configuration menu
    Copy the full SHA
    2ddc2a0 View commit details
    Browse the repository at this point in the history

  8. fixed a test thats failing due to inappropriate inputs. 

    - 13456 is an invalid video ID, its too short.
    @techdragon
    techdragon committed Aug 22, 2013
    Configuration menu
    Copy the full SHA
    085b650 View commit details
    Browse the repository at this point in the history