Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Travis deployment condition #115

Merged
merged 2 commits into from Jan 22, 2020
Merged

Fix Travis deployment condition #115

merged 2 commits into from Jan 22, 2020

Conversation

timgraham
Copy link
Contributor

Broken in 2e6e526

(untested, may not work)

@timgraham
Copy link
Contributor Author

@Djailla, does it look like it might work?

@coveralls
Copy link

coveralls commented Jan 21, 2020

Coverage Status

Coverage remained the same at 100.0% when pulling 0a97a81 on deployment-condition into cd11ce7 on master.

@Djailla
Copy link

Djailla commented Jan 22, 2020

Looks good to me !

@jezdez
Copy link
Member

jezdez commented Jan 22, 2020

Hey folks sorry for the breakage, it would be better to just use build stages for this so no condition is needed. I'll update the branch with the needed change..

@jezdez jezdez merged commit 9ac1a7b into master Jan 22, 2020
@jezdez jezdez deleted the deployment-condition branch January 22, 2020 09:18
@jezdez
Copy link
Member

jezdez commented Jan 22, 2020

@timgraham Let me know if this doesn't works out when you redo the 4.0 tag. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants