Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add i18n tags #149

Merged
merged 1 commit into from Mar 30, 2022
Merged

Add i18n tags #149

merged 1 commit into from Mar 30, 2022

Conversation

MrCordeiro
Copy link
Contributor

Added the i18n translation tags for the remaining messages.

@MrCordeiro
Copy link
Contributor Author

Hi @bee-keeper! Are you still active on this project?

@valberg
Copy link
Contributor

valberg commented Mar 30, 2022

Hey @MrCordeiro

Lets get this in! But first: Why the autoescape off tags?

@MrCordeiro
Copy link
Contributor Author

Wouldn't be better to wait until #172 is finished first? Otherwise, you won't be able to release the package on pypi. Or activate the Github Actions test workflow?

Anyways I was just following the setup @bee-keeper was using

So... this PR is so old. I've been using my own fork of django-invitation for a while, so I would be ok if this PR was abandoned..

@valberg
Copy link
Contributor

valberg commented Mar 30, 2022

@MrCordeiro the test workflow is in full effect (https://github.com/jazzband/django-invitations/actions) :)

Let us merge it in! As you say it conforms to other code 👍

@valberg valberg merged commit d64680b into jazzband:master Mar 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants