FieldTracker should patch save_base instead of save #404
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FieldTracker does not see update_fields changed in tracked model.save() method
This change allows proper capturing update_fields kwarg if is is changed in overridden save() method.
Codecov Report
@@ Coverage Diff @@
## master #404 +/- ##
==========================================
- Coverage 94.08% 93.95% -0.14%
==========================================
Files 6 6
Lines 744 744
==========================================
- Hits 700 699 -1
- Misses 44 45 +1
Continue to review full report at Codecov.
|
auvipy
approved these changes
Dec 15, 2019
tumb1er
added a commit
to tumb1er/django-model-utils
that referenced
this pull request
Sep 13, 2021
auvipy
pushed a commit
that referenced
this pull request
Oct 8, 2021
* Add tracker context manager and decorator * Handle auto-field warning in tests * Use tracker context in monkey-patched methods * Test delaying set_saved_fields call with context manager * Docs for tracker context * Describe FieldsContext context manager in changes * Fix unused import * #494 add breaking changes note on 4.1.1 release for #404 * #494 fix typo * #494 add docstring for FieldsContext * #494 move breaking changes from 4.1.1 to 4.1.0 * #494 fix typo and add some more docstrings
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
If model with
FieldTrackeradds extra fields toupdate_fieldsinsave, these changes are not reflected in FieldTracker state.Solution
FieldTrackershould patchsave_baseinstead ofsave:save_baseis called fromsaveso finalupdate_fieldsvalue is capturedsave_baseis never overridden inmodels.ModelsubclassesCommandments
CHANGES.rstfile to describe the changes, and quote according issue withGH-<issue_number>.