Send submission to entire newsletter if subscriptions are empty #110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
hmm, I see that introducing custom related_name breaks things. Will repair tests. |
|
Ok, wrote another test that seems to cover this case. Initially, Submission.from_message, that is used extensively in the tests, seems to copy subscriptions from newsletter, which is not exactly replicates the case when submission is created from web with no subscriptions added explicitly. |
sutyrin
changed the title
dokterbob
changed the title
|
I forked this repo and implemented this pull request for my own purposes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey,
Thanks for great app.
Caption for Submission.subscriptions says:
I've stumbled upon this non-working and supposedly fixed, it works for me.
Please review, thanks!