Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to GitHub Actions. #358

Merged
merged 6 commits into from
Mar 10, 2021
Merged

Migrate to GitHub Actions. #358

merged 6 commits into from
Mar 10, 2021

Conversation

jezdez
Copy link
Member

@jezdez jezdez commented Jan 28, 2021

Travis CI has a new pricing model which places limits on open source.

Many projects are moving to GitHub Actions instead, including Jazzband projects:

This is based on jazzband/contextlib2#26.

It drops support for Python 3.5 because GitHub Actions doesn't fully support them. It's EOL anyway.

Python 3.9 support is also added.

This also relates to #343 in that it enables the release workflow mentioned there with @dokterbob as proejct lead. The version is deducted from the last git tag automatically using setuptools_scm.

TODO:

  • @jezdez to add JAZZBAND_RELEASE_KEY to the repo secrets.

@jezdez jezdez added this to In progress in Migrate to GitHub Actions via automation Jan 28, 2021
@codecov
Copy link

codecov bot commented Jan 28, 2021

Codecov Report

❗ No coverage uploaded for pull request base (master@51be647). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #358   +/-   ##
=========================================
  Coverage          ?   86.02%           
=========================================
  Files             ?       16           
  Lines             ?     1302           
  Branches          ?      137           
=========================================
  Hits              ?     1120           
  Misses            ?      135           
  Partials          ?       47           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 51be647...15adbe3. Read the comment docs.

@jezdez jezdez added this to the 1.0b1 milestone Jan 28, 2021
@jezdez jezdez requested a review from dokterbob January 28, 2021 18:02
@jezdez jezdez moved this from In progress to In review in Migrate to GitHub Actions Jan 28, 2021
@jezdez jezdez requested a review from claudep February 4, 2021 11:05
@jezdez
Copy link
Member Author

jezdez commented Feb 4, 2021

@claudep Hey, I've added you as well since you've done some work on this library and I want to make sure we move this along. This is fully in line what all the other Jazzband projects have done FWIW.

@claudep
Copy link
Collaborator

claudep commented Feb 4, 2021

Sorry, I'm no longer active on django-newsletter.

@jezdez
Copy link
Member Author

jezdez commented Feb 4, 2021

Sorry, I'm no longer active on django-newsletter.

Got it, thank you!

@jezdez jezdez requested review from aleksihakli and removed request for claudep February 4, 2021 11:28
@jezdez
Copy link
Member Author

jezdez commented Feb 9, 2021

@aleksihakli Apologies for pulling you into this, I want to move ahead with this pull request and your review would be much appreciated!

@aleksihakli
Copy link
Member

aleksihakli commented Feb 9, 2021

Hey @jezdez! I've been a bit busy but I'll review this today. Feel free to ping me via mail or on GitHub in case you need any help, I'll happily assist if I have the bandwidth :)

@jezdez
Copy link
Member Author

jezdez commented Feb 9, 2021

Hey @jezdez! I've been a bit busy but I'll review this today. Feel free to ping me via mail or on GitHub in case you need any help, I'll happily assist if I have the bandwidth :)

Understood and no problem, thank you for getting back to me :)

Migrate to GitHub Actions automation moved this from In review to Reviewed Feb 9, 2021
Copy link
Member

@aleksihakli aleksihakli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! setup.py package classifiers should probably also include Python 3.9 and possibly Django version classifiers?

setup.py Show resolved Hide resolved
@jezdez jezdez merged commit c350966 into master Mar 10, 2021
Migrate to GitHub Actions automation moved this from Reviewed to Done Mar 10, 2021
@jezdez jezdez deleted the gha branch March 10, 2021 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants