Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make FastFixtureTestCase work in Django 1.7. #208

Closed
wants to merge 1 commit into from

Conversation

Pike
Copy link

@Pike Pike commented May 1, 2015

See also issue #193.

I wish I had an idea on how to write tests for this.

I didn't look into the transaction stuff in detail yet, and I'm not exactly sure if it's easy to resolve those in a backwards compatible manner.

@Pike Pike closed this May 1, 2015
@Pike Pike reopened this May 1, 2015
@Pike
Copy link
Author

Pike commented May 1, 2015

@erikrose
Copy link
Contributor

erikrose commented May 1, 2015

I consider this green. The reds are just ssl timeouts while downloading packages.

@jwhitlock
Copy link
Contributor

@Pike - This happens a lot - TravisCI, PyPi have occasional bad network days. When this happens, I re-run the failing build, rather than close/open.

When you click through to the failing build (https://travis-ci.org/django-nose/django-nose/jobs/60884311), do you see a grey reload button in the upper right corner? This might only be available to project owners.

rebuild button

@Pike
Copy link
Author

Pike commented May 2, 2015

Only find the rerun button on my own projects, but not here, sadly.

@jwhitlock
Copy link
Contributor

Thanks for doing my research 😄 I've hit the reload buttons, we'll get it green. It's a busy weekend, so I'll have to look closer in a few days.

@jwhitlock
Copy link
Contributor

Wow, that was one busy weekend.

@Pike - Could you rebase this onto the new master? I've made quite a few changes and it won't merge cleanly anymore. git rebase -i master might do the trick.

I've also added some basic database tests in testapp/tests.py, but none using FastFixtureTestCase. I'd appreciate some tests, which may just be a copy of the UsesFixtureTestCase.

@jwhitlock
Copy link
Contributor

I'd like to see some tests for FastFixtureTestCase (issue #220) before I merge fixes.

@Pike
Copy link
Author

Pike commented Aug 5, 2015

I'm afraid I took this as far as I could. This works in django <= 1.7, but breaks because the enter_transaction_management (internal?) api was killed in 1.8 and above. How to write the code in a way that doesn't break is sadly beyond my understanding of that code :-(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants