Skip to content

Commit

Permalink
Hotfix- CODE_CHALLENGE instead of CODE_VERIFIER in docs (#1208)
Browse files Browse the repository at this point in the history
* Hotfix- CODE_CHALLENGE instead of CODE_VERIFIER in docs

* HotFix- code_challenge_method added for authorization call in docs

* Fix: mandatory documentation to submit PR added
  • Loading branch information
matiseni51 committed Oct 4, 2022
1 parent 9383e08 commit da459a1
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 1 deletion.
1 change: 1 addition & 0 deletions AUTHORS
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,7 @@ Julien Palard
Jun Zhou
Kaleb Porter
Kristian Rune Larsen
Matias Seniquiel
Michael Howitz
Paul Dekkers
Paul Oswald
Expand Down
3 changes: 3 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,9 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

## [unreleased]

### Added
* Add 'code_challenge_method' parameter to authorization call in documentation

### Added
* Add 'code_verifier' parameter to token requests in documentation

Expand Down
3 changes: 2 additions & 1 deletion docs/getting_started.rst
Original file line number Diff line number Diff line change
Expand Up @@ -275,12 +275,13 @@ Take note of ``code_challenge`` since we will include it in the code flow URL. I

To start the Authorization code flow go to this `URL`_ which is the same as shown below::

http://127.0.0.1:8000/o/authorize/?response_type=code&code_challenge=XRi41b-5yHtTojvCpXFpsLUnmGFz6xR15c3vpPANAvM&client_id=vW1RcAl7Mb0d5gyHNQIAcH110lWoOW2BmWJIero8&redirect_uri=http://127.0.0.1:8000/noexist/callback
http://127.0.0.1:8000/o/authorize/?response_type=code&code_challenge=XRi41b-5yHtTojvCpXFpsLUnmGFz6xR15c3vpPANAvM&code_challenge_method=S256&client_id=vW1RcAl7Mb0d5gyHNQIAcH110lWoOW2BmWJIero8&redirect_uri=http://127.0.0.1:8000/noexist/callback

Note the parameters we pass:

* **response_type**: ``code``
* **code_challenge**: ``XRi41b-5yHtTojvCpXFpsLUnmGFz6xR15c3vpPANAvM``
* **code_challenge_method**: ``S256``
* **client_id**: ``vW1RcAl7Mb0d5gyHNQIAcH110lWoOW2BmWJIero8``
* **redirect_uri**: ``http://127.0.0.1:8000/noexist/callback``

Expand Down

0 comments on commit da459a1

Please sign in to comment.