Added oauth2_settings.RESOURCE_SERVER_INTROSPECTION_RESPONSE_FIELD setting to let po… #1347
Conversation
…sibility to change field used Signed-off-by: Fillau <jm.fillau@gmail.com>
fijemax
force-pushed
the
feat/add-resource-server-subject-field
branch
from
39ed5e0
to
d2d57cf
Compare
for more information, see https://pre-commit.ci
fijemax
changed the title
Codecov Report
@@ Coverage Diff @@
## master #1347 +/- ##
=======================================
Coverage 97.54% 97.54%
=======================================
Files 32 32
Lines 2120 2120
=======================================
Hits 2068 2068
Misses 52 52
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
@fijemax, I think I see your need here. The user is being fetched or created here. The current implementation uses username as the key field. Username may not be set as it's an optional in the response and frankly we don't know the required fields on someones usermodel so this approach is a bit naieve. I think this approach might work for your use case, but at the moment I don't think I have enough context to be confident this is a good fix that will work for the wider community. I'm gonna do some digging around this method so I better understand how it's used. Can you please provide more detail on your use case in your original issue to provide more context? @n2ygk, do you have thoughts? |
|
@dopry @fijemax I have not been following this issue. Isn't getting the sub or other added claims described here? Or here for userinfo. |
|
Isn't this accomplished by #1325? |
|
Hello, |
|
@fijemax please edit the PR description. I've initialized it with the PR template. |
|
I believe this feature is resolved by #1325 |
Fixes #1325
Description of the Change
Checklist
CHANGELOG.mdupdated (only for user relevant changes)AUTHORS