Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare the Django 1.9 compatibility #306

Merged
merged 14 commits into from
Oct 16, 2015

Conversation

dulacp
Copy link
Contributor

@dulacp dulacp commented Oct 15, 2015

urlpatterns should be a plain list or django.conf.urls.url instances.

As stated by the Django documentation, and Django 1.9 will probably remove it.

Cheers

As stated by the Django documentation, and Django 1.9 removed the
patterns method
@Psykopear Psykopear added this to the 0.10.0 milestone Oct 15, 2015
@Psykopear Psykopear self-assigned this Oct 15, 2015
@Psykopear
Copy link
Contributor

Hi @dulaccc,

could you please add django 1.9 to the tests matrix to verify this incompatibility?
Furthermore, would you be interested to continue the work for django 1.9's support?
Otherwise I will continue the development from your commit.

Cheers

@dulacp
Copy link
Contributor Author

dulacp commented Oct 15, 2015

I'll do that for the matrix

And I am very interested in continuing the django 1.9 compatibility since we will be using asap this version in our new project.
So feel free to assign it to me :) I'm working on Django 1.9 on a daily basis right now.

@dulacp
Copy link
Contributor Author

dulacp commented Oct 15, 2015

I am fixing the errors one by one, and dropping support for the couple py26-django19 since their specify dropping support in the release notes, do you validate this choice ?

@palazzem
Copy link
Contributor

Hi @dulaccc ,
actually we're working on DOT's Django versions and Python interpreters support keeping them in sync with the provided release notes. This process removes Python interpreters and early Django versions so we're sure that newer versions of DOT will work only on maintained Django versions.

In your case, it's totally fine dropping python 2.6 for Django 1.9 because it's not supported anymore; proceed leaving the rest of the test matrix as is and let us know when your PR will be ready for the community review!

Thanks again!

@dulacp
Copy link
Contributor Author

dulacp commented Oct 15, 2015

Cristal clear !
Still some a compatibility issue to fix under python 2.6 and then it will be all green :)

But maybe we should keep this PR open until Django 1.9 hits the first release candidate I guess.

@palazzem
Copy link
Contributor

It will be great having a ready to merge compatibility branch, while waiting for the official release. I think that probably it's better holding the merge, at least, for the RC1 (16 November?) because we may need intermediate milestones. @synasius what do you think about this?

Anyway, I'm also in favor of a merge (if these changes will not break any Django < 1.9) and a second double-check before any statement about our support to Django 1.9. So we can close and easily merge this PR without any (possible) future conflict.

@dulacp
Copy link
Contributor Author

dulacp commented Oct 15, 2015

Totally agree with you, now the branch should be ready to merge, just waiting for the travis builds to show up

@@ -90,6 +97,12 @@ deps =
Django<1.9
{[testenv]deps}

[testenv:py33-django19]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this environment can be remove since py33 support is dropped in 1.9

https://docs.djangoproject.com/en/1.8/faq/install/#what-python-version-can-i-use-with-django

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

right, I removed it form the matrix but forgot the tox.ini file, good catch !

@dulacp
Copy link
Contributor Author

dulacp commented Oct 16, 2015

Btw, I took the liberty to upgrade the Travis architecture with sudo: false. It improves a lot the stability of tests, especially the connection throughput for the pip install for instance.

@masci
Copy link
Contributor

masci commented Oct 16, 2015

@dulaccc definitely a good choice moving to container-based infrastructure on Travis. 👍

@synasius
Copy link
Contributor

great! we are ready to merge 👍

@dulacp
Copy link
Contributor Author

dulacp commented Oct 16, 2015

Yeah! I will continue to keep this branch ready to merge with the next django:stable/1.9.x commits

@palazzem
Copy link
Contributor

Talking with @synasius , we've decided to merge your PR now preventing merge conflicts in the future :)
Anyway, as I said before, we'll do a double check prior the next DOT release. If you want to keep your compatibility contribution (let's say, if something changes in Django 1.9), you can open a new branch / PR.

Again, thanks a lot for your contribution!

@palazzem palazzem merged commit 042ca54 into jazzband:master Oct 16, 2015
@dulacp
Copy link
Contributor Author

dulacp commented Oct 16, 2015

Fair enough, this way everyone can keep working more freely :)

My pleasure to contribute to such a well structured project !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants