-
-
Notifications
You must be signed in to change notification settings - Fork 774
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prepare the Django 1.9 compatibility #306
Conversation
As stated by the Django documentation, and Django 1.9 removed the patterns method
Hi @dulaccc, could you please add django 1.9 to the tests matrix to verify this incompatibility? Cheers |
I'll do that for the matrix And I am very interested in continuing the django 1.9 compatibility since we will be using asap this version in our new project. |
I am fixing the errors one by one, and dropping support for the couple py26-django19 since their specify dropping support in the release notes, do you validate this choice ? |
Hi @dulaccc , In your case, it's totally fine dropping python 2.6 for Django 1.9 because it's not supported anymore; proceed leaving the rest of the test matrix as is and let us know when your PR will be ready for the community review! Thanks again! |
Cristal clear ! But maybe we should keep this PR open until Django 1.9 hits the first release candidate I guess. |
It will be great having a ready to merge compatibility branch, while waiting for the official release. I think that probably it's better holding the merge, at least, for the RC1 (16 November?) because we may need intermediate milestones. @synasius what do you think about this? Anyway, I'm also in favor of a merge (if these changes will not break any Django < 1.9) and a second double-check before any statement about our support to Django 1.9. So we can close and easily merge this PR without any (possible) future conflict. |
3f3c4af
to
8043ffb
Compare
Totally agree with you, now the branch should be ready to merge, just waiting for the travis builds to show up |
ade66a6
to
89d6e3f
Compare
@@ -90,6 +97,12 @@ deps = | |||
Django<1.9 | |||
{[testenv]deps} | |||
|
|||
[testenv:py33-django19] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this environment can be remove since py33 support is dropped in 1.9
https://docs.djangoproject.com/en/1.8/faq/install/#what-python-version-can-i-use-with-django
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
right, I removed it form the matrix but forgot the tox.ini
file, good catch !
Btw, I took the liberty to upgrade the Travis architecture with |
@dulaccc definitely a good choice moving to container-based infrastructure on Travis. 👍 |
great! we are ready to merge 👍 |
Yeah! I will continue to keep this branch ready to merge with the next |
Talking with @synasius , we've decided to merge your PR now preventing merge conflicts in the future :) Again, thanks a lot for your contribution! |
Fair enough, this way everyone can keep working more freely :) My pleasure to contribute to such a well structured project ! |
urlpatterns
should be a plain list ordjango.conf.urls.url
instances.Cheers