Fixes #405 and #406 #407
Merged
Fixes #405 and #406 #407
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good @bastbnl |
|
Do you think it would be possible to extend the tox setup to include Django 1.10 here? I can merge this but I'd prefer to not do it blindly and think that would make sure that nothing in the future breaks it as well. |
|
@poswald we will update the CI to run the tests with django 1.10 and the development branch asap |
|
Excellent. Thank you for that. |
|
We have this abysmal practice of recreating and running migrations each time we deploy... is there any way to delay migrations or something to get around this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
Thanks again for the project and the docs! I encountered two issues while running this code on #405 and #406. I've not tested the code on older versions of Django.