add tax rate to the PurchasedItem #224
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PetrDlouhy
force-pushed
the
purchased_item_tax_rate
branch
from
8e3aea9
to
dc208df
Compare
Codecov Report
@@ Coverage Diff @@
## master #224 +/- ##
=======================================
Coverage 79.57% 79.57%
=======================================
Files 27 27
Lines 1611 1611
Branches 192 192
=======================================
Hits 1282 1282
Misses 225 225
Partials 104 104 Continue to review full report at Codecov.
|
PetrDlouhy
force-pushed
the
purchased_item_tax_rate
branch
from
dc208df
to
120ff8d
Compare
WhyNotHugo
requested changes
Oct 10, 2020
There was a problem hiding this comment.
The intent here makes sense to me, but I think it would be a lot better to use typing.NamedTuple.
It's a lot easier to read, and setting default is less hacky.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PayU provider needs to state every item price including tax in contrast with PayPal, that needs the price without tax.
So if the
PurchasedItem.priceis without tax I don't have enough information for PayU implementation.I think, that it would be best to add tax rate, because some theoretical provider could need tax rate stated for every item (every item could have different rate).