Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to GitHub Actions. #246

Merged
merged 5 commits into from
Jan 2, 2021
Merged

Migrate to GitHub Actions. #246

merged 5 commits into from
Jan 2, 2021

Conversation

jezdez
Copy link
Member

@jezdez jezdez commented Dec 30, 2020

Travis CI has a new pricing model which places limits on open source.

Many projects are moving to GitHub Actions instead, including Jazzband projects:

This is based on jazzband/contextlib2#26.

No more mention of Travis CI in the codebase:

$ git grep -i travis
$

TODO:

  • @jezdez to add JAZZBAND_RELEASE_KEY to the repo secrets.

@codecov
Copy link

codecov bot commented Dec 30, 2020

Codecov Report

Merging #246 (b2847a7) into master (4d8cc6b) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #246   +/-   ##
=======================================
  Coverage   80.10%   80.10%           
=======================================
  Files          27       27           
  Lines        1659     1659           
  Branches      191      191           
=======================================
  Hits         1329     1329           
  Misses        227      227           
  Partials      103      103           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4d8cc6b...bcb6866. Read the comment docs.

@jezdez jezdez added this to In progress in Migrate to GitHub Actions via automation Dec 30, 2020
@jezdez jezdez moved this from In progress to In review in Migrate to GitHub Actions Dec 30, 2020
Copy link
Member

@WhyNotHugo WhyNotHugo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was unaware of the Travis plan changes. Thanks for sharing the details behind this.

Can we also push the packages to GH releases? (kinda like this)

.github/workflows/release.yml Show resolved Hide resolved
Migrate to GitHub Actions automation moved this from In review to Reviewed Jan 2, 2021
Copy link
Member

@WhyNotHugo WhyNotHugo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@jezdez jezdez merged commit 85d096b into master Jan 2, 2021
Migrate to GitHub Actions automation moved this from Reviewed to Done Jan 2, 2021
@jezdez jezdez deleted the gha branch January 2, 2021 22:21
@jezdez
Copy link
Member Author

jezdez commented Jan 2, 2021

I was unaware of the Travis plan changes. Thanks for sharing the details behind this.

Can we also push the packages to GH releases? (kinda like this)

Woops, I missed this comment, let me check how this could work in combination with the PyPA GitHub action we're using to publish the release to the Jazzband package index. I'll open a ticket.

Copy link
Member

@aleksihakli aleksihakli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

tox.ini Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants