Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expanded documentation for Web Push #558

Merged
merged 1 commit into from Aug 16, 2023

Conversation

nlittlejohns
Copy link
Contributor

• Added example code to register WP device
• Fixed issue where call to extract UserAgent didn't include UA
• Added examples on how to send a Web Push message

• Added example code to register WP device
• Fixed issue where call to extract UserAgent didn't include UA
• Added examples on how to send a Web Push message
@Andrew-Chen-Wang
Copy link
Member

Is it necessary to add MS Edge?

@jamaalscarlett jamaalscarlett merged commit bd387e9 into jazzband:master Aug 16, 2023
blighj pushed a commit to blighj/django-push-notifications that referenced this pull request Sep 30, 2023
• Added example code to register WP device
• Fixed issue where call to extract UserAgent didn't include UA
• Added examples on how to send a Web Push message
blighj pushed a commit to blighj/django-push-notifications that referenced this pull request Sep 30, 2023
• Added example code to register WP device
• Fixed issue where call to extract UserAgent didn't include UA
• Added examples on how to send a Web Push message
jamaalscarlett pushed a commit that referenced this pull request Oct 8, 2023
* Add WebPush support for Safari

* Update webpush.py based on review

Declare results variable at the start of the block

* Fix typo in warning

Co-authored-by: Cuyler Stuwe <salembeats@gmail.com>

* Update README.rst

Co-authored-by: James Bligh <618250+blighj@users.noreply.github.com>

* Fix mailto: space

* Expanded documentation for Web Push (#558)

• Added example code to register WP device
• Fixed issue where call to extract UserAgent didn't include UA
• Added examples on how to send a Web Push message

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Attempt to fix tests

* Update README.rst

---------

Co-authored-by: James Bligh <james.bligh@silvercloudhealth.com>
Co-authored-by: Cuyler Stuwe <salembeats@gmail.com>
Co-authored-by: Éloi Rivard <eloi.rivard@nubla.fr>
Co-authored-by: Neil Littlejohns <n.littlejohns@gmail.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants