Change feature detection logic for database field #612
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As of now
HexIntegerField
relies onconnection.settings_dict["ENGINE"]
to determinate if the database supports specific feature.Since a custom engine may be defined by any user this has some limitation because engines are hard-coded.
The preferred approach would be to use
connection.feature_class.<feature>
, but ATM there is no flag in these classes which may help here (ie:supports_unsigned_integers
).My solution here is to rely on
connection.vendor
because it should be more robust and could handle subclassing of any existent backend, if that backend has some kind of differences it could just overridevendor
attribute (ie:postgresql
->custom-postgresql
).Also this saves us some configurations since
django.db.backends.postgresql
,django.db.backends.postgresql_psycopg2
anddjango.contrib.gis.db.backends.postgis
have allvendor = "posrgresql"
, and we also get spatiallite (which is based on sqlite and has the same datatypes).