Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add category to aps_data dict #80

Closed
wants to merge 1 commit into from
Closed

add category to aps_data dict #80

wants to merge 1 commit into from

Conversation

t-io
Copy link
Contributor

@t-io t-io commented Sep 19, 2014

@jleclanche
Copy link
Member

Can you fix your git user.name and user.email please? I need those if you want credit.

Fix the indent issues as well and gtm.

@t-io
Copy link
Contributor Author

t-io commented Sep 19, 2014

Thanks for reply. I'm not sure if I get you right. I change the indentation to just one tab and updated my git name and email.

@jleclanche
Copy link
Member

Yes that is fine.
Can you squash it into a single commit in your name please?

By the way you might want to add that email in your github profile in order to get credit on github itself as well.

@t-io
Copy link
Contributor Author

t-io commented Sep 24, 2014

I squashed it to a single commit. By the way when you plan the next pip release?

@jleclanche
Copy link
Member

Not for another 2 weeks at least I don't think. You can ping me on the 10th of September and I can probably do a release then.

@jleclanche
Copy link
Member

@t-io The author on that commit is still broken. Run git commit --amend --author="Your Name <your@email>" and then git push -f to update the pr.

@t-io
Copy link
Contributor Author

t-io commented Sep 25, 2014

I updated the commit with git commit --amend -C HEAD --reset-author and forced the push. That should do it.

@jleclanche
Copy link
Member

Yep. Thank you for your contribution.

@jleclanche jleclanche closed this Sep 25, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants