Add support redis-py 3.0.0 #344
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 16, 2018
|
Extending |
|
@michael-k Good call! In the latest version I've updated tox & Travis to test against both redis-py 2.x and 3.x. Thanks for the suggestion. |
django_redis/client/default.py:37:41: W504 line break after binary operator tests/test_backend.py:548:21: W504 line break after binary operator tests/test_backend.py:550:22: W504 line break after binary operator tests/test_backend.py:604:22: W504 line break after binary operator
Session data is always text.
- Make CacheKey inherit from str to fix exception "Only bytes, strings and numbers (ints, longs and floats) are acceptable for keys and values." - .exists() now returns and integer, so update .has_key(). - Update test matrix to include tests for both redis-py 2.x and the latest version. Fixes #342
|
@TheOldMop I've incorporated your test fixes from #335 so we can verify all tests pass. Thanks! |
|
@jdufresne I didn't notice this on the queue, but not sure if you want to look at terencehonles@a4f7781 for the |
|
Thanks. Looks mostly identical. |
|
Nice work! Thank you all. |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
strto fix exception "Only bytes, strings and numbers (ints, longs and floats) are acceptable for keys and values.".exists()now returns and integer, so update.has_key().Fixes #342