Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Very long TravisCI builds #70

Closed
browniebroke opened this issue Nov 6, 2020 · 4 comments
Closed

Very long TravisCI builds #70

browniebroke opened this issue Nov 6, 2020 · 4 comments

Comments

@browniebroke
Copy link
Member

Problem

I recently submitted a couple of pull requests to fix some issues I was having, and noticed that the TravisCI build was very slow, sometimes taking several hours to just start and a couple more to finish.

This seems caused by Travis recent pricing change which limit open source to 1000 minutes, I suppose jazzband is hitting this quota very quickly.

Since this is not an issue specific to django-redshift-backend, I first tried to reach out on IRC, but I'm not sure if my message went through....

Procedure to reproduce the problem

Example of pull request: #68
Build for the first commit: https://travis-ci.org/github/jazzband/django-redshift-backend/builds/741443844

PR submitted on 4th Nov 5:06pm GMT
Build started 5th Nov 1:32am GMT
Build finished 5th Nov 3:30am GMT

Suggested Solution

I think it's easy to agree that this is not sustainable for contributors and even less for maintainers. I'd be happy to help, but first I'd like to confirm the CI that the Jazzband org wants to use. I assume Github actions is the easiest these days as it doesn't require maintainers to grant anything and it has a generous free allowance.

The only part I'm seeing where we would need a maintainer to step in is to add the PyPI token to the repository secrets to keep release automation working.

FYI @jezdez as roadie and @shimizukawa as recent active maintainer...

@jezdez
Copy link
Member

jezdez commented Nov 6, 2020

Yeah, GitHub actions is the way to go here and I plan to spend time this year to work on this. E.g. prettytable has a good setup on GA already: https://github.com/jazzband/prettytable/blob/master/.github/workflows/test.yml

@jezdez
Copy link
Member

jezdez commented Nov 6, 2020

Just wanted to say, if you have time to work on this, this would be incredibly useful!

@browniebroke
Copy link
Member Author

Ok. I tried to stay close to the current Travis config: #71

I can't test the final step to publish the package, but the rest works. The status check are not showing up in the pull request, I'm guessing it's due to the workflow not being in the main branch yet.

I'm open to suggestions to make the config less verbose. I'm planning to fix up #68 once it's merged.

@browniebroke
Copy link
Member Author

Fixed now. CI was moved to GH actions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants