Migrate to Github Actions #71

browniebroke · 2020-11-06T15:02:14Z

Subject: Move CI to Github as Travis builds have become too slow

Feature or Bugfix

Feature

Purpose

Move the CI to Github Actions. The config is a bit more verbose than I'd like to, but this should have the advantage to be explicit.

Detail

Fixes Very long TravisCI builds #70

Relates

I have another PR that will conflict: #68

Given that Travis is too painful to work with, I'll update that other PR when this is merged.

⚠️ IMPORTANT ⚠️

A project admin will have to add JAZZBAND_RELEASE_KEY to the repo secrets: https://github.com/jazzband/django-redshift-backend/settings/secrets/actions/new

browniebroke · 2020-11-06T15:04:09Z

django_redshift_backend/base.py

+            raise NotSupportedError(
+                'DISTINCT ON fields is not supported by this database backend'
+            )


This was failing flake8.

browniebroke · 2020-11-06T15:05:11Z

.github/workflows/ci.yml

+      - uses: actions/checkout@v2
+      - uses: actions/setup-python@v2
+        with:
+          python-version: 3.6


Note that the deploy step used to run on Python 2.7.

Since django-redshift-backend doesn't create a binary wheel, so I don't think that's a problem.

browniebroke · 2020-11-06T15:08:55Z

Not sure why the builds aren't running, but they do run on my fork: https://github.com/browniebroke/django-redshift-backend/actions?query=workflow%3ACI

shimizukawa

LGTM!
Thanks!!

shimizukawa · 2020-11-08T08:22:35Z

.github/workflows/ci.yml

+
+      - name: Publish packages
+        if: github.event_name == 'push' && startsWith(github.ref, 'refs/tags')
+        uses: pypa/gh-action-pypi-publish@v1.4.1


I don't know about the Jazzband way of releasing, but I think pypa/gh-action-pypi-publish with the API provided by PyPI would be better in the future.

@jezdez please check this deploy section. After you agree on the deploy section, we can merge this PR.

This isn't using the Jazzband package index, so will need to update to use it. I'll get to do a proper review later tonight. Don't merge this before.

I looked at Jazzband's release process and I think I get it... Packages are not published to PyPI directly, they are first going to Jazzband package index which in turns publich to PyPI? I'll copy the publish part from prettytable, should be a good starting point.

shimizukawa · 2020-11-08T08:25:16Z

.github/workflows/ci.yml

+      - uses: actions/checkout@v2
+      - uses: actions/setup-python@v2
+        with:
+          python-version: 3.6


Since django-redshift-backend doesn't create a binary wheel, so I don't think that's a problem.

shimizukawa · 2020-11-08T08:27:00Z

.github/workflows/ci.yml

+
+      - name: Tox tests
+        shell: bash
+        run: tox -e ${{ matrix.versions.tox }}


I've seen the results of your execution. I think it's perfect 🎉
https://github.com/browniebroke/django-redshift-backend/runs/1364264120

jezdez · 2020-11-08T11:41:45Z

Please use tox-gh-actions for configuring the test matrix instead of duplicating it in the GH actions and tox configuration. This is along the lines we've done with tox-travis.

browniebroke · 2020-11-08T13:40:11Z

Updated test to use tox-gh-actions and deployment steps to use Jazzband package index.

Build result: https://github.com/browniebroke/django-redshift-backend/actions/runs/352344702

jezdez

Thanks, this is looking more and more like what we need, thank you for working on this!

A few things that would be better:

separate test, lint and deploy workflows like in prettytable
the deploy workflow should use the "published" event type instead of checking manually for the existence of a git tag

.github/workflows/ci.yml

browniebroke · 2020-11-08T21:09:47Z

I think it's all done. Let me know if I missed anything.

browniebroke · 2020-11-23T09:45:37Z

Is there anything else I need to change here?

shimizukawa · 2020-12-10T21:06:55Z

@browniebroke Thank you for your work!

@jezdez I'm going to release a new version after merging this PR. What do we need next?

shimizukawa · 2020-12-31T23:27:31Z

@jezdez ping and Happy New Year!!

jezdez · 2021-01-03T14:57:46Z

I've fixed a few more things in #72. Closing this PR since I wasn't able to push to the branch of this PR being in a fork repo.

shimizukawa · 2021-01-03T21:19:59Z

Now I've released 2.0.0. Thanks for your contribution!
https://pypi.org/project/django-redshift-backend/2.0.0/

browniebroke added 5 commits November 6, 2020 14:29

Move CI to Github Actions

06c969b

Move CI to Github Actions - take 2

b6e543e

Fix flake8 error

c899afc

Add deployment step

b786ee7

Tidy up

881bfaf

browniebroke commented Nov 6, 2020

View reviewed changes

Update trigger for CI workflow

b4859a2

browniebroke mentioned this pull request Nov 6, 2020

Very long TravisCI builds #70

Closed

shimizukawa approved these changes Nov 8, 2020

View reviewed changes

shimizukawa requested a review from jezdez November 8, 2020 08:37

shimizukawa mentioned this pull request Nov 8, 2020

Add support for up to Django 3.1 & Python 3.9 #68

Closed

browniebroke force-pushed the gh-actions branch 3 times, most recently from a68c17e to 9e634fd Compare November 8, 2020 13:26

Simplify test matrix with tox-gh-actions

4522fdd

browniebroke force-pushed the gh-actions branch from 9e634fd to 4522fdd Compare November 8, 2020 13:27

browniebroke added 3 commits November 8, 2020 13:33

Exclude unsuitable matrix combinations

8309124

Add Python 3.5 back

a2876bf

Update deployment steps to use Jazzband index

1ef2bfe

jezdez requested changes Nov 8, 2020

View reviewed changes

.github/workflows/ci.yml Outdated Show resolved Hide resolved

browniebroke force-pushed the gh-actions branch from da95c9c to c1b0b3b Compare November 8, 2020 21:03

Split CI workflow into test, lint and deploy

6e90872

browniebroke force-pushed the gh-actions branch from c1b0b3b to 6e90872 Compare November 8, 2020 21:04

browniebroke changed the title ~~MIgrate to Github Actions~~ Migrate to Github Actions Nov 9, 2020

jezdez mentioned this pull request Jan 3, 2021

Migrate to GitHub Actions #72

Merged

1 task

jezdez closed this Jan 3, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Migrate to Github Actions #71

Migrate to Github Actions #71

browniebroke commented Nov 6, 2020 •

edited

browniebroke Nov 6, 2020

browniebroke Nov 6, 2020

shimizukawa Nov 8, 2020

browniebroke commented Nov 6, 2020

shimizukawa left a comment

shimizukawa Nov 8, 2020

shimizukawa Nov 8, 2020

jezdez Nov 8, 2020

browniebroke Nov 8, 2020

shimizukawa Nov 8, 2020

shimizukawa Nov 8, 2020

jezdez commented Nov 8, 2020

browniebroke commented Nov 8, 2020

jezdez left a comment

browniebroke commented Nov 8, 2020

browniebroke commented Nov 23, 2020

shimizukawa commented Dec 10, 2020

shimizukawa commented Dec 31, 2020

jezdez commented Jan 3, 2021

shimizukawa commented Jan 3, 2021

Migrate to Github Actions #71

Migrate to Github Actions #71

Conversation

browniebroke commented Nov 6, 2020 • edited

Feature or Bugfix

Purpose

Detail

Relates

⚠️ IMPORTANT ⚠️

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

browniebroke commented Nov 6, 2020

shimizukawa left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jezdez commented Nov 8, 2020

browniebroke commented Nov 8, 2020

jezdez left a comment

Choose a reason for hiding this comment

browniebroke commented Nov 8, 2020

browniebroke commented Nov 23, 2020

shimizukawa commented Dec 10, 2020

shimizukawa commented Dec 31, 2020

jezdez commented Jan 3, 2021

shimizukawa commented Jan 3, 2021

browniebroke commented Nov 6, 2020 •

edited