Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add AUTO_REFRESH setting #104

Merged
merged 4 commits into from
Jul 28, 2018
Merged

Add AUTO_REFRESH setting #104

merged 4 commits into from
Jul 28, 2018

Conversation

rphlo
Copy link
Contributor

@rphlo rphlo commented Jul 24, 2018

Implement enhancement #37

@belugame
Copy link
Collaborator

@rphlo thanks a lot for this feature. I m happy to merge it in. 2 things.
a) we need unit tests that cover it e.g. assert that the token expiry timestamp is (not) extended when expected.
b) I would make the 1 second threshold bigger to avoid hitting the database more than it is useful for this usecase. 5 or even 10 seconds seems reasonable for me

@rphlo
Copy link
Contributor Author

rphlo commented Jul 26, 2018

@belugame what about using freezegun in tests? This would add a dependency but would bring many benefit in my point of view for the tests...

@belugame
Copy link
Collaborator

@rphlo sure, I m familiar with freezegun. Feel free to add it to tox.ini

@belugame belugame merged commit 50cfb7b into jazzband:develop Jul 28, 2018
@belugame
Copy link
Collaborator

@rphlo Thank you for the work again, I extended your unit tests and tweaked things elsewhere unrelated to your changes. Glad to have your review my changes. #105

dontexit pushed a commit to dontexit/django-rest-knox that referenced this pull request Jan 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants