Enable customizing login/logout responses

[c-w]

This pull request is a small change to enable customizing the response shape for the login and logout views by overriding a simple method.

This is useful in situations where for example the 204 responses in the logout views are undesirable (e.g. for clients that always assume that responses have a JSON body).

[AdamDonna]

This looks very reasonable to me 👍
I think you're good to merge if I can get another +1.
@giovannicimolin does this look good to you?

[giovannicimolin]

@c-w Thanks for the contribution! 😁

I'll be reviewing these changes in the next week or so.
I don't have a lot of bandwidth but I'll try to keep things moving.

CC @AdamDonna

[johnraz]

This LGTM as well, maybe worth adding to the documentation though.

[c-w]

This LGTM as well, maybe worth adding to the documentation though.

Where would you like me to document this @johnraz ?

[johnraz]

i guess here: https://github.com/jazzband/django-rest-knox/blob/develop/docs/views.md

[giovannicimolin]

👍

LGTM, changes look good and there's some interest in this being merged.

I think this is almost good to merge, but I agree with @johnraz that it needs some documentation. If you add those docs in, I'll make sure to review and move this along. 😁

[c-w]

it needs some documentation

I added the docs in 43d983d. PTAL @giovannicimolin

[codecov]

Codecov Report

❗ No coverage uploaded for pull request base (develop@3a1bc58). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             develop     #296   +/-   ##
==========================================
  Coverage           ?   91.70%           
==========================================
  Files              ?        9           
  Lines              ?      229           
  Branches           ?       35           
==========================================
  Hits               ?      210           
  Misses             ?       16           
  Partials           ?        3           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[giovannicimolin]

👍

CI checks are green, we're good to go.
@c-w Thanks for your contribution. 😁