Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update tests to test Python 3.8 and Django 3.0 #104

Merged
merged 5 commits into from
Feb 4, 2020

Conversation

brianmay
Copy link
Collaborator

@brianmay brianmay commented Dec 2, 2019

No description provided.

@coveralls
Copy link

coveralls commented Dec 2, 2019

Coverage Status

Coverage remained the same at 100.0% when pulling 728d4b9 on brianmay:update_tests into da78089 on TracyWebTech:master.

@brianmay
Copy link
Collaborator Author

brianmay commented Dec 2, 2019

Python 3.8 and Django 2.2 support currently broken, see tests.

@brianmay
Copy link
Collaborator Author

brianmay commented Dec 2, 2019

Actually Python 3.8 is fine, just doesn't work with older Django versions. Probably need to change the tests not to test older versions of Django with Python 3.8

@brianmay brianmay mentioned this pull request Dec 3, 2019
@brianmay
Copy link
Collaborator Author

brianmay commented Dec 3, 2019

Tests should really support Django 3.0 now too.

@vlinhart
Copy link
Contributor

vlinhart commented Feb 4, 2020

Hello, don't know how to really do this. So I did a fork of this pull and added the changes needed. Now the tests are run for Django 2.2, 3 and python 3.8 as well.
brianmay#1

@brianmay
Copy link
Collaborator Author

brianmay commented Feb 4, 2020

It is a bit weird, and had me slightly confused, however, I think you did the right thing. Thanks

@brianmay brianmay changed the title Update tests to test Python 3.8 and Django 2.2 Update tests to test Python 3.8 and Django 3.0 Feb 4, 2020
@brianmay brianmay merged commit d91b9ce into jazzband:master Feb 4, 2020
@brianmay brianmay deleted the update_tests branch February 4, 2020 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants