Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix double scheme output if set in site domain #70

Merged
merged 1 commit into from Feb 26, 2017

Conversation

yakky
Copy link
Member

@yakky yakky commented Feb 4, 2017

Fix #62

@yakky yakky added this to the 3.0 milestone Feb 4, 2017
@codecov
Copy link

codecov bot commented Feb 4, 2017

Codecov Report

Merging #70 into master will increase coverage by 0.76%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master      #70      +/-   ##
==========================================
+ Coverage   64.92%   65.69%   +0.76%     
==========================================
  Files           7        7              
  Lines         134      137       +3     
  Branches       14       15       +1     
==========================================
+ Hits           87       90       +3     
  Misses         41       41              
  Partials        6        6
Impacted Files Coverage Δ
robots/views.py 73.84% <100%> (+1.26%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1f71d20...e4b1752. Read the comment docs.

@yakky
Copy link
Member Author

yakky commented Feb 11, 2017

@tyapkov would you tests if this PR fixes your issues with #62 ?

@tyapkov
Copy link
Contributor

tyapkov commented Feb 14, 2017

@yakky update solves the problem, but now sitemap record in robots.txt is always shown with protocol.

@yakky
Copy link
Member Author

yakky commented Feb 15, 2017

@tyapkov is this comment still true after #62 (comment)?

@yakky
Copy link
Member Author

yakky commented Feb 15, 2017

I anyway rebased it on top of the current master which also includes the fix to detect the correct request protocol

@yakky yakky merged commit 01316d2 into jazzband:master Feb 26, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants