Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not crash when silk app is not included in urls #443

Merged
merged 1 commit into from
Oct 15, 2020
Merged

Do not crash when silk app is not included in urls #443

merged 1 commit into from
Oct 15, 2020

Conversation

asalahli
Copy link
Contributor

@asalahli asalahli commented Oct 1, 2020

Hi,

Right now SilkyMiddleware raises NoReverseMatch when silk.urls are not included in the app. There are various reasons when one might not want to enable the Silk UI, but still keep the middleware around. For example, to disable Silk in production, the easiest way would be to set SILKY_INTERCEPT_PERCENT to 0, and not include the URLs. Unless there's a reason to keep the exception in place, I'd like to have Silk handle this gracefully.

This is my first time posting here, so I'm not too familiar with the development process. Happy to address any feedback.

Thanks

@auvipy auvipy merged commit 0fdedea into jazzband:master Oct 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants