Do not crash when silk app is not included in urls #443
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
Right now
SilkyMiddleware
raisesNoReverseMatch
whensilk.urls
are not included in the app. There are various reasons when one might not want to enable the Silk UI, but still keep the middleware around. For example, to disable Silk in production, the easiest way would be to setSILKY_INTERCEPT_PERCENT
to 0, and not include the URLs. Unless there's a reason to keep the exception in place, I'd like to have Silk handle this gracefully.This is my first time posting here, so I'm not too familiar with the development process. Happy to address any feedback.
Thanks