fix: DataCollector sql_queries model not found on filter(request=self…

[armanjtehrani]

Closes #475

After digging into silk DataCollector, I figured out in the second line of this section of the code no sql query is returned. So the part where adds model to query dictionaries, can't do it's job and we face the error issued in #475

models.SQLQuery.objects.bulk_create(sql_queries)
sql_queries = models.SQLQuery.objects.filter(request=self.request)

By changing these 2 lines to sql_queries = models.SQLQuery.objects.bulk_create(sql_queries), sql_queries is no longer empty and the rest of the system can function correctly.

[codecov]

Codecov Report

Merging #476 (5b90a3a) into master (7e93d6c) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #476      +/-   ##
==========================================
- Coverage   82.83%   82.82%   -0.01%     
==========================================
  Files          50       50              
  Lines        2051     2050       -1     
==========================================
- Hits         1699     1698       -1     
  Misses        352      352              

Impacted Files	Coverage Δ
silk/collector.py	79.41% <100.00%> (-0.16%)	⬇️
silk/__init__.py
silk/urls.py
project/project/__init__.py	60.00% <0.00%> (ø)
project/project/urls.py	100.00% <0.00%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7e93d6c...5b90a3a. Read the comment docs.

[auvipy]

can you please add a test for the changes?

[armanjtehrani]

can you please add a test for the changes?

I currently don't know exactly for what reason this issue happens. Should check it out further.

[Archmonger]

Fairly insignificant code coverage change, and I don't believe tests are needed for just changing how the variable is assigned.

Will merge.

[Archmonger]

Reverted this merge due to this issue with meta profiling

Exception when performing meta profiling, dumping trace below
Traceback (most recent call last):
  File "C:\Users\username\Documents\Repositories\Conreq\.venv\lib\site-packages\silk\middleware.py", line 132, in _process_response
    collector.finalise()
  File "C:\Users\username\Documents\Repositories\Conreq\.venv\lib\site-packages\silk\collector.py", line 189, in finalise
  File "C:\Users\username\Documents\Repositories\Conreq\.venv\lib\site-packages\django\db\models\fields\related_descriptors.py", line 1015, in set
    self.add(*new_objs, through_defaults=through_defaults)
  File "C:\Users\username\Documents\Repositories\Conreq\.venv\lib\site-packages\django\db\models\fields\related_descriptors.py", line 950, in add
    self._add_items(
  File "C:\Users\username\Documents\Repositories\Conreq\.venv\lib\site-packages\django\db\models\fields\related_descriptors.py", line 1126, in _add_items
    target_ids = self._get_target_ids(target_field_name, objs)
  File "C:\Users\username\Documents\Repositories\Conreq\.venv\lib\site-packages\django\db\models\fields\related_descriptors.py", line 1062, in _get_target_ids
    raise ValueError(
ValueError: Cannot add "<SQLQuery: SQLQuery object (None)>": the value for field "sqlquery" is None

[auvipy]

you should not have merge this on the first place.

[Archmonger]

I agree with you, my mistake.