Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure sorting between most db queries requests #484

Merged
merged 1 commit into from
Aug 28, 2021

Conversation

ErwinJunge
Copy link
Contributor

This PR ensures that the result in the "Most Database Queries" is actually sorted in descending order. The previous code could result in the results being out of order since the ordering was applied seperately per view_name.

@ErwinJunge
Copy link
Contributor Author

@auvipy could you hit the button to approve the workflow run?

@auvipy
Copy link
Contributor

auvipy commented Jul 1, 2021

done

@codecov
Copy link

codecov bot commented Jul 1, 2021

Codecov Report

Merging #484 (cd3c7c2) into master (7e93d6c) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #484   +/-   ##
=======================================
  Coverage   82.83%   82.83%           
=======================================
  Files          50       50           
  Lines        2051     2051           
=======================================
  Hits         1699     1699           
  Misses        352      352           
Impacted Files Coverage Δ
silk/views/summary.py 91.93% <100.00%> (ø)
silk/urls.py
silk/__init__.py
project/project/urls.py 100.00% <0.00%> (ø)
project/project/__init__.py 60.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7e93d6c...cd3c7c2. Read the comment docs.

Copy link
Contributor

@auvipy auvipy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you check the build failures? also shouldn't we update unit tests for the change?

@ErwinJunge
Copy link
Contributor Author

can you check the build failures? also shouldn't we update unit tests for the change?

The build failures aren't related to the code changes in the PR. In fact, they're also present in https://github.com/jazzband/django-silk/pull/479/checks which doesn't do any code changes at all. It looks like master is broken.

Regarding updating the unit tests: I agree, that was a bit of an oversight on my end. I'll update them asap.

@auvipy
Copy link
Contributor

auvipy commented Jul 4, 2021

but test needed for all the proposed changes

@Andrew-Chen-Wang
Copy link
Member

@auvipy ref: psycopg/psycopg2#1293 looking to see if anyone else has a solution in jazz band discussion. If not, then we can merge #486

@Archmonger
Copy link
Contributor

Archmonger commented Aug 26, 2021

As per Jazzband testing guidelines I don't think this one needs a unit test.

@Andrew-Chen-Wang could you merge in the latest commits from jazzband/django-silk:master into this branch and see if that cleans up the test failures?

@auvipy auvipy merged commit 777ca9c into jazzband:master Aug 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants