-
-
Notifications
You must be signed in to change notification settings - Fork 328
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ensure sorting between most db queries requests #484
Conversation
@auvipy could you hit the button to approve the workflow run? |
done |
Codecov Report
@@ Coverage Diff @@
## master #484 +/- ##
=======================================
Coverage 82.83% 82.83%
=======================================
Files 50 50
Lines 2051 2051
=======================================
Hits 1699 1699
Misses 352 352
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you check the build failures? also shouldn't we update unit tests for the change?
The build failures aren't related to the code changes in the PR. In fact, they're also present in https://github.com/jazzband/django-silk/pull/479/checks which doesn't do any code changes at all. It looks like master is broken. Regarding updating the unit tests: I agree, that was a bit of an oversight on my end. I'll update them asap. |
but test needed for all the proposed changes |
@auvipy ref: psycopg/psycopg2#1293 looking to see if anyone else has a solution in jazz band discussion. If not, then we can merge #486 |
As per Jazzband testing guidelines I don't think this one needs a unit test. @Andrew-Chen-Wang could you merge in the latest commits from |
This PR ensures that the result in the "Most Database Queries" is actually sorted in descending order. The previous code could result in the results being out of order since the ordering was applied seperately per view_name.