Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix egg metadata error #485

Merged
merged 1 commit into from
Aug 14, 2021
Merged

Fix egg metadata error #485

merged 1 commit into from
Aug 14, 2021

Conversation

Archmonger
Copy link
Contributor

@Archmonger Archmonger commented Jul 6, 2021

The current instructions in the readme regarding alternative installation methods states to use pip install -e git+https://github.com/jazzband/django-silk.git#egg=silk. However, this is incorrect and will result in the following error:

Obtaining silk from git+https://github.com/jazzband/django-silk.git#egg=silk
  Cloning https://github.com/jazzband/django-silk.git to c:\users\username\repositories\conreq\.venv\src\silk
  Running command git clone -q https://github.com/jazzband/django-silk.git 'c:\users\username\repositories\conreq\.venv\src\silk'
  WARNING: Generating metadata for package silk produced metadata for project name django-silk. Fix your #egg=silk fragments.
WARNING: Discarding git+https://github.com/jazzband/django-silk.git#egg=silk. Requested django-silk from git+https://github.com/jazzband/django-silk.git#egg=silk has inconsistent name: filename has 'silk', but metadata has 'django-silk'
ERROR: Could not find a version that satisfies the requirement silk (unavailable) (from versions: none)
ERROR: No matching distribution found for silk (unavailable)

This PR changes the instructions to use pip install -e git+https://github.com/jazzband/django-silk.git#egg=django-silk

@codecov
Copy link

codecov bot commented Jul 6, 2021

Codecov Report

Merging #485 (6df4718) into master (7e93d6c) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #485   +/-   ##
=======================================
  Coverage   82.83%   82.83%           
=======================================
  Files          50       50           
  Lines        2051     2051           
=======================================
  Hits         1699     1699           
  Misses        352      352           
Impacted Files Coverage Δ
silk/urls.py
silk/__init__.py
project/project/urls.py 100.00% <0.00%> (ø)
project/project/__init__.py 60.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7e93d6c...6df4718. Read the comment docs.

@tiltec
Copy link

tiltec commented Aug 14, 2021

Test failures are definitely unrelated to changes in this PR, so this seems good to go.

I just became a Jazzband member to merge this PR ;) It's actually quite easy!

@tiltec tiltec merged commit 7f03cfe into jazzband:master Aug 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants