Fixed a bug that the profile tab could not be opened when the source … #490
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…code contained Japanese. There was a bug that the profile tab could not be opened when the source code contained Japanese. The error message is as follows. 'cp932' codec can't decode byte 0x88 in position 19: illegal multibyte sequence Obviously, it is due to a character code problem. Basically, the source code should be written in UTF-8, so I explicitly specified to read it in utf-8.
Codecov Report
@@ Coverage Diff @@
## master #490 +/- ##
=======================================
Coverage 82.83% 82.83%
=======================================
Files 50 50
Lines 2051 2051
=======================================
Hits 1699 1699
Misses 352 352
Continue to review full report at Codecov.
|
|
Great addition, thanks! |
This was referenced Oct 27, 2022
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a bug that the profile tab could not be opened when the source code contained Japanese. The error message is as follows.
'cp932' codec can't decode byte 0x88 in position 19: illegal multibyte sequence
Obviously, it is due to a character code problem.
Basically, the source code should be written in UTF-8, so I explicitly specified to read it in utf-8.