Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Make Migrations #503

Merged
merged 7 commits into from
Oct 12, 2021
Merged

Conversation

Archmonger
Copy link
Contributor

@Archmonger Archmonger commented Oct 11, 2021

Based on Daadu's PR

Migration file not needed due to default_auto_field.

@Archmonger Archmonger self-assigned this Oct 11, 2021
@codecov
Copy link

codecov bot commented Oct 11, 2021

Codecov Report

Merging #503 (db6d081) into master (2a30739) will increase coverage by 0.05%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #503      +/-   ##
==========================================
+ Coverage   84.61%   84.67%   +0.05%     
==========================================
  Files          50       51       +1     
  Lines        2061     2068       +7     
==========================================
+ Hits         1744     1751       +7     
  Misses        317      317              
Impacted Files Coverage Δ
silk/apps.py 100.00% <100.00%> (ø)
project/project/__init__.py 75.00% <0.00%> (+15.00%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2a30739...db6d081. Read the comment docs.

Copy link
Contributor

@auvipy auvipy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

goo job

silk/apps.py Outdated Show resolved Hide resolved
project/tests/test_app_config.py Outdated Show resolved Hide resolved
@auvipy auvipy merged commit 432eb96 into jazzband:master Oct 12, 2021
@Archmonger Archmonger deleted the remove-make-migrations branch October 15, 2021 22:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants