Multipart forms and RawPostDataException #592
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s it, it breaks any other readers including middleware and views. This skips the request body for those forms.
Codecov Report
@@ Coverage Diff @@
## master #592 +/- ##
==========================================
+ Coverage 84.60% 84.64% +0.03%
==========================================
Files 52 52
Lines 2072 2077 +5
==========================================
+ Hits 1753 1758 +5
Misses 319 319
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
albertyw
approved these changes
Oct 12, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Multipart forms only allow reading request.body once. In the silk RequestModelFactory, it reads the request.body. This breaks any future reading of request.body in middleware or in views. request.POST or request.FILES will all result in a RawPostDataException. The proposal is to not read request.body for these type of requests since profiling them is still valuable, even without the request body being saved.