#46 Retain ordering, view style and limit #614
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SebCorbin
force-pushed
the
46-remember-ordering-view-style
branch
from
13b18a9
to
8b179a9
Compare
Codecov Report
@@ Coverage Diff @@
## master #614 +/- ##
==========================================
+ Coverage 84.63% 86.25% +1.61%
==========================================
Files 52 52
Lines 2076 2080 +4
==========================================
+ Hits 1757 1794 +37
+ Misses 319 286 -33
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
albertyw
approved these changes
Oct 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two enhancements in this PR:
'show', 'order_by', 'order_dir', 'view_style'params are retained so when you click on the "Requests" menu item, you keep these (they won't be reset when "Clear all filters" is clicked as they are not filters)I will open a cleanup issue, as I find the filters form heavily relying on JavaScript, and it should not be IMHO.