Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Outsource all inline scripts and styles #635

Merged
merged 5 commits into from Jan 15, 2023
Merged

Conversation

sgelis
Copy link
Contributor

@sgelis sgelis commented Dec 26, 2022

Fixes #531.

Tests pass and manual testing shows no regression as far as I can tell.

@codecov
Copy link

codecov bot commented Dec 26, 2022

Codecov Report

Merging #635 (074001a) into master (deb9b1f) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #635   +/-   ##
=======================================
  Coverage   86.33%   86.33%           
=======================================
  Files          52       52           
  Lines        2093     2093           
=======================================
  Hits         1807     1807           
  Misses        286      286           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@albertyw
Copy link
Member

albertyw commented Jan 5, 2023

@sgelis Sorry, it looks like I accidentally closed this pull request when I tried rebasing it on top of #639 to get the tests to pass. Since the pull request is closed, I also can't push your changes back to your repository fork.

Your branch still exists at https://github.com/albertyw/django-silk/tree/sgelis-master but you'll need to grab the code on that branch again, push the changes to github, and reopen this pull request. You can do that with

git remote add albertyw git@github.com:albertyw/django-silk
git fetch albertyw
git cherry-pick 97a5d33
git cherry-pick c4cd70a
git push

I also created sgelis#1 as another way to get your commits back in your repository.

@sgelis
Copy link
Contributor Author

sgelis commented Jan 5, 2023

@albertyw I merged sgelis#1 but this does not seem to reopen this PR which still seems emptied 😕

@albertyw albertyw reopened this Jan 5, 2023
@albertyw albertyw self-assigned this Jan 7, 2023
@albertyw albertyw self-requested a review January 7, 2023 04:18
@albertyw albertyw merged commit 415529c into jazzband:master Jan 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hard to integrate with CSP rules in place
2 participants