Skip to content

Commit

Permalink
Refactored exclude fields to another method.
Browse files Browse the repository at this point in the history
  • Loading branch information
Alig1493 committed Dec 12, 2018
1 parent c53cfe5 commit 61c8ab3
Showing 1 changed file with 6 additions and 6 deletions.
12 changes: 6 additions & 6 deletions simple_history/manager.py
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,11 @@ def get_queryset(self):
key_name = self.instance._meta.pk.name
return self.get_super_queryset().filter(**{key_name: self.instance.pk})

def get_excluded_fields(self):
if isinstance(self.instance._meta.model.history, self.__class__):
return self.instance._meta.model.history.model._history_excluded_fields
return []

def most_recent(self):
"""
Returns the most recent copy of the instance available in the history.
Expand All @@ -45,12 +50,7 @@ def most_recent(self):
)
)
tmp = []
excluded_fields = []

if isinstance(self.instance._meta.model.history, self.__class__):
excluded_fields = (
self.instance._meta.model.history.model._history_excluded_fields
)
excluded_fields = self.get_excluded_fields()

for field in self.instance._meta.fields:
if isinstance(field, models.ForeignKey):
Expand Down

0 comments on commit 61c8ab3

Please sign in to comment.