Skip to content

Commit

Permalink
Remove changeReason and update CHANGES to prepare for 3.0.0 (#819)
Browse files Browse the repository at this point in the history
* Remove changeReason and update CHANGES

* call out breaking changes
  • Loading branch information
barm committed Apr 16, 2021
1 parent c888fcf commit 67c7c43
Show file tree
Hide file tree
Showing 2 changed files with 16 additions and 12 deletions.
19 changes: 16 additions & 3 deletions CHANGES.rst
Original file line number Diff line number Diff line change
Expand Up @@ -3,16 +3,29 @@ Changes

Unreleased
----------

3.0.0 (2021-04-16)
----------

Breaking changes:

- Removed support for Django 3.0
- Removed `changeReason` in favor of `_change_reason` (see 2.10.0)

Full list of changes:

- Removed support for Django versions prior to 2.2 (gh-652)
- Migrate from TravisCI to Github Actions (gh-739)
- Add Python 3.9 support (gh-745)
- Support ``ignore_conflicts`` in ``bulk_create_with_history`` (gh-733)
- Use ``asgiref`` when available instead of thread locals (gh-747)
- Sort imports with isort (gh-751)
- Queryset ``history.as_of`` speed improvements by calculating in the DB (gh-758)
- Increase `black` and `isort` python version to 3.6
- Remove Django 3.0 support
- Add Django 3.2 support
- Increase `black` and `isort` python version to 3.6 (gh-817)
- Remove Django 3.0 support (gh-817)
- Add Django 3.2 support (gh-817)
- Improve French translations (gh-811)
- Remove support for changeReason (gh-819)

2.12.0 (2020-10-14)
-------------------
Expand Down
9 changes: 0 additions & 9 deletions simple_history/utils.py
Original file line number Diff line number Diff line change
Expand Up @@ -164,13 +164,4 @@ def get_change_reason_from_object(obj):
if hasattr(obj, "_change_reason"):
return getattr(obj, "_change_reason")

if hasattr(obj, "changeReason"):
warning_msg = (
"Using the attr changeReason to populate history_change_reason is"
" deprecated in 2.10.0 and will be removed in 3.0.0. Use "
"_change_reason instead. "
)
warnings.warn(warning_msg, DeprecationWarning)
return getattr(obj, "changeReason")

return None

0 comments on commit 67c7c43

Please sign in to comment.