Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

providing_args deprecation warning Django 3.1 #723

Closed
deeprave opened this issue Oct 6, 2020 · 3 comments
Closed

providing_args deprecation warning Django 3.1 #723

deeprave opened this issue Oct 6, 2020 · 3 comments

Comments

@deeprave
Copy link

deeprave commented Oct 6, 2020

Describe the bug
Django 3.1 issues this deprecation warning:

..../simple_history/signals.py:4: RemovedInDjango40Warning: The providing_args argument is deprecated. As it is purely documentational, it has no replacement. If you rely on this argument as documentation, you can move the text to a code comment or docstring.
    pre_create_historical_record = django.dispatch.Signal(

... and same again on line 14 for post_create_historical_record.

To Reproduce
Steps to reproduce the behavior:

  1. run the addon using Django 3.1
  2. run some test or action which triggers the pre and/or post signal
  3. See deprecation warning

Expected behavior
No deprecation warning :-)

Environment (please complete the following information):

  • OS: MacOS 10.14.6
  • Browser N/A (I see this in pytest output)
  • Django Simple History Version: 2.11.0
  • Django Version: 3.1.2
  • Database Version: postgresql 12.4

Additional context
Should be reproducible anywhere.

@ThePumpingLemma
Copy link
Collaborator

This was already fixed in #702

We're planning on cutting release within the next week or so.

@deeprave
Copy link
Author

deeprave commented Oct 8, 2020

Awesome, thanks!

@rituraj123db
Copy link

/home/ideal48/Projects/order_service/venv/lib/python3.8/site-packages/safedelete/signals.py:5: RemovedInDjango40Warning: The providing_args argument is deprecated. As it is pure documentation, it has no replacement. If you rely on this argument as documentation, you can move the text to a code comment or docstring.
post_undelete = ModelSignal(providing_args=["instance", "using"], use_caching=True)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants