Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for Django 4.x #172

Closed
one4many opened this issue Dec 19, 2021 · 2 comments
Closed

Support for Django 4.x #172

one4many opened this issue Dec 19, 2021 · 2 comments
Labels
type:bug
Milestone
Version 0.7

Comments

@one4many
Copy link

one4many commented Dec 19, 2021 •
edited

  1. Since Django 3.1 providing_args in the Signal dispatcher has been marked deprecated:
    providing_args deprecation warning Django 3.1 jazzband/django-simple-history#723

It has been removed in 4.x with no replacement and 0.6.5 is considered incompatible/broken with Django 4.x

Just remove the argument providing_args or convert it to a documentation string.

  1. Since Django 3.1 urls from 'from django.conf.urls import url' has been marked deprecated and has been removed in Django 4.x.

Please use re_path in order to be compatible again.
apragacz added a commit that referenced this issue Dec 22, 2021
@apragacz
Add Django 4.x support (#172)
760567d
apragacz added a commit that referenced this issue Dec 22, 2021
@apragacz
Add Django 4.x support (#172)
812b780
@apragacz
Copy link
Owner

Hi @one4many,
thanks for raising this.
I was aware of the deprecation, but I missed the Django 4.0 release :)
I hope to release the fix till the end of this year (probably as version 0.7.0).

@apragacz apragacz added this to the Version 0.7 milestone Dec 22, 2021
apragacz added a commit that referenced this issue Dec 22, 2021
@apragacz
Add Django 4.x support (#172)
b47cc94 
Also:
*   Drop official support for Django 1.x
apragacz added a commit that referenced this issue Dec 22, 2021
@apragacz
Add Django 4.x support (#172)
0d97460 
Also:
*   Drop official support for Django 1.x
apragacz added a commit that referenced this issue Dec 22, 2021
@apragacz
Bump version to 0.7.0
e3785cb 
Changes:

*   Add Django 4.x support (#172)
*   Drop official support for Django 1.x
*   Drop official support for Python 3.4
@apragacz
Copy link
Owner

Support for Django 4.x was released via 0.7.0 version. Hope it works as expected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type:bug
Projects
None yet
Milestone
Version 0.7
Development

No branches or pull requests
2 participants
@apragacz @one4many