Test that translation files are compiled #1207
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See setup-python's docs on caching: https://github.com/actions/setup-python/blob/main/docs/advanced-usage.md#caching-packages
Not really sure what has been changed, just that these files had changes in them when compiling them locally.
Multiple packages installed during some of the somewhat recent workflow runs were not fetched from cache, as the pinned package versions were updated in requirements files, and not in `setup.py` or `tox.ini` - which caused the cached package versions to remain unchanged after updating the pinned versions.
|
@valberg @hramezani @joshuadavidthomas Btw, do notify me if you'd like to not be tagged to review PRs anymore :) |
Codecov Report
@@ Coverage Diff @@
## master #1207 +/- ##
=======================================
Coverage 97.29% 97.29%
=======================================
Files 23 23
Lines 1259 1259
Branches 204 204
=======================================
Hits 1225 1225
Misses 16 16
Partials 18 18 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
valberg
approved these changes
Jul 10, 2023
|
Great work @ddabble - and just keep tagging me, I'm more than happy to help review stuff :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds a new job to the
test.ymlworkflow file that fails if any of the.potranslation files have changes in them that are not reflected in the corresponding.mofiles (624708c). (This was largely based on stefanfoulis/django-phonenumber-field#446).Additional changes
test.yml(c171ccd, 1fba14e, 13c9c0a)Related Issue
Motivation and Context
This should make it easier for PR reviewers to verify that the
.mofiles have been properly compiled/updated.How Has This Been Tested?
Through GitHub Actions.
Screenshots (if appropriate):
Types of changes
Checklist:
pre-commit runcommand to format and lint.AUTHORS.rstCHANGES.rst