Compatibility patch for Django 1.4 #2
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Does this change work with Django 1.2 and 1.3 or is this backwards incompatible? |
| @@ -145,7 +145,10 @@ def create_historical_record(self, instance, type): | |||
| manager = getattr(instance, self.manager_name) | |||
| attrs = {} | |||
| for field in instance._meta.fields: | |||
| attrs[field.attname] = getattr(instance, field.attname) | |||
| if isinstance(field, models.ForeignKey): | |||
| attrs[field.name] = getattr(instance, field.attname) | |||
There was a problem hiding this comment.
Should attname be name instead here?:
attrs[field.name] = getattr(instance, field.name)
This was referenced Jul 17, 2012
barm
pushed a commit
to barm/django-simple-history
that referenced
this pull request
Dec 9, 2018
# This is the 1st commit message: Update admin.py # The commit message jazzband#2 will be skipped: # Update test_admin.py # The commit message jazzband#3 will be skipped: # Update test_admin.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I ran into trouble using the library with Django 1.4. I haven't been able to fully comprehend what broke, but the Choices, Polls example in the README was broken as seen in #Issue: #1
I'm not sure this is a complete patch, since I'm not sure what changed in 1.4 to cause the break (The release notes don't indicate a change in behavior, but the code is definitely different).
I'd be happy to clean this up if you can hint me where there are changes in internals of Django.