Set attribute on history list entries, from evaluated admin methods #390
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #390 +/- ##
=========================================
+ Coverage 97.47% 97.5% +0.02%
=========================================
Files 15 15
Lines 595 600 +5
Branches 73 76 +3
=========================================
+ Hits 580 585 +5
Misses 9 9
Partials 6 6
Continue to review full report at Codecov.
|
|
Adding tests. |
kseever
reviewed
May 15, 2018
simple_history/admin.py
Outdated
| # Set attribute on each action_list entry from admin methods | ||
| for x in history_list_display: | ||
| if getattr(self, x, None) and callable(getattr(self, x)): | ||
| history_method = getattr(self, x) |
There was a problem hiding this comment.
The three getattr()s are a little wasteful. Can you pull it into a local instead?
for to_display in history_list_display:
history_method = getattr(self, to_display, None)
if history_method and callable(history_method):
for list_entry in action_list:
setattr(list_entry, to_display, history_method(list_entry))
|
Failing flake8 style @blawson |
simple_history/admin.py
Outdated
| @@ -61,6 +61,13 @@ def history_view(self, request, object_id, extra_context=None): | |||
| if not self.has_change_permission(request, obj): | |||
| raise PermissionDenied | |||
|
|
|||
| # Set attribute on each action_list entry from admin methods | |||
| for x in history_list_display: | |||
There was a problem hiding this comment.
change from x to a more descriptive var name
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change will allow admin pages that extend SimpleHistoryAdmin to provide admin methods that will be evaluated on each object in the change list.
I.e., you can update history_list_display with a method, defined in the admin, that will be evaluated and set on each object.