Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds german translations #484

Merged
merged 2 commits into from
Nov 21, 2018
Merged

Adds german translations #484

merged 2 commits into from
Nov 21, 2018

Conversation

funkyfuture
Copy link
Contributor

Motivation and Context

It makes the app more accessible to users with german as mother tongue. Also, a new section in the contributing doc may encourage users to add more translations.

How Has This Been Tested?

Installed in a project, checked the admin forms. Some of the strings didn't appear (and neither did the origins).

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have run the make format command to format my code
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@codecov-io
Copy link

codecov-io commented Nov 21, 2018

Codecov Report

Merging #484 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #484   +/-   ##
=======================================
  Coverage   97.19%   97.19%           
=======================================
  Files          16       16           
  Lines         713      713           
  Branches       94       94           
=======================================
  Hits          693      693           
  Misses         10       10           
  Partials       10       10

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7c09da2...6f192fe. Read the comment docs.

Copy link
Collaborator

@rossmechanic rossmechanic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this @funkyfuture !

@rossmechanic rossmechanic merged commit 53421d9 into jazzband:master Nov 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants