Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove get_excluded_fields function from manager – shouldn't be part … #515

Merged
merged 1 commit into from
Jan 16, 2019

Conversation

rossmechanic
Copy link
Collaborator

…of public API

Description

In #477, get_excluded_fields was added to the history manager since the initial version of that PR had a more complicated function definition for get_excluded_fields. Since that function is only now used in one place and only consists of one line, I'd rather not have it part of the public API for history manager, so I'm removing it before the next release.

Related Issue

Motivation and Context

How Has This Been Tested?

All current tests pass

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have run the make format command to format my code
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have added my name and/or github handle to AUTHORS.rst
  • I have added my change to CHANGES.rst
  • All new and existing tests passed.

@codecov-io
Copy link

codecov-io commented Jan 16, 2019

Codecov Report

Merging #515 into master will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #515      +/-   ##
==========================================
- Coverage   97.71%   97.71%   -0.01%     
==========================================
  Files          17       17              
  Lines         832      830       -2     
  Branches      114      114              
==========================================
- Hits          813      811       -2     
  Misses          8        8              
  Partials       11       11
Impacted Files Coverage Δ
simple_history/manager.py 93.93% <100%> (-0.18%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9deb217...f546802. Read the comment docs.

Copy link
Collaborator

@kseever kseever left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good to me.

@rossmechanic rossmechanic merged commit 9c9b735 into master Jan 16, 2019
@rossmechanic rossmechanic deleted the remove-unnecessary-function branch January 16, 2019 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants