feat: add default_date optional parameter for bulk create and update #687
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbor23
force-pushed
the
feat-default-date
branch
from
a0bf928
to
ee7424d
Compare
12 tasks
|
Hi @sbor23 not sure what happened with the hooks for travis. Can you try repushing this so I can see tests? |
sbor23
force-pushed
the
feat-default-date
branch
from
ee7424d
to
2ff83c8
Compare
Sure, did that :) |
rossmechanic
requested changes
Aug 5, 2020
simple_history/manager.py
Outdated
Comment on lines
130
to
131
| history_date=default_date | ||
| or getattr(instance, "_history_date", timezone.now()), |
There was a problem hiding this comment.
Would prefer that this follow the pattern of _history_user, such that _history_date takes precedence over default_date
There was a problem hiding this comment.
Ah true, _history_date gives more fine-grained control so it should take precedence. Haven't really used it yet. :)
sbor23
force-pushed
the
feat-default-date
branch
from
2ff83c8
to
ace6334
Compare
rossmechanic
approved these changes
Aug 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add default_date parameter for bulk creating and updating historical entries.
Description
This change adds a keyword argument
default_dateto thebulk_history_create()method on theHistoryManager, as well as the utility functionsbulk_create_with_history()andbulk_update_with_history().If provided, the created or updated history entries will have the field
history_dateset to this date.Related Issue
#686
Motivation and Context
It provides an easy way to set the history_date when dealing with bulk operations.
How Has This Been Tested?
Unittests have been added.
Types of changes
Checklist:
make formatcommand to format my codeAUTHORS.rstCHANGES.rst