Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: clean_old_history's days argument acccepts integer #722

Merged
merged 5 commits into from
Oct 5, 2020
Merged

fix: clean_old_history's days argument acccepts integer #722

merged 5 commits into from
Oct 5, 2020

Conversation

vied12
Copy link
Contributor

@vied12 vied12 commented Oct 5, 2020

Description

clean_old_history command does not accept value for --days argument

Related Issue

#721

Motivation and Context

How Has This Been Tested?

Locally tested

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have run the make format command to format my code
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have added my name and/or github handle to AUTHORS.rst
  • I have added my change to CHANGES.rst
  • All new and existing tests passed.

rossmechanic
rossmechanic approved these changes Oct 5, 2020
View reviewed changes
Copy link
Collaborator

@rossmechanic rossmechanic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @vied12

@rossmechanic rossmechanic merged commit a3d3a2d into jazzband:master Oct 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rossmechanic rossmechanic rossmechanic approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@vied12 @rossmechanic