Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update GitHub Actions migration to match other Jazzband projects. #769

Merged
merged 5 commits into from
Jan 2, 2021

Conversation

jezdez
Copy link
Member

@jezdez jezdez commented Dec 30, 2020

Description

I'm currently porting all of Jazzband projects to GitHub Actions and this
is a minor update to #738 (thank you @ThePumpingLemma!).

It does drop Python 3.5 support though since that's EOL'd now.

It also adds Jazzband releases again after it was removed in #738. @rossmechanic Please make sure to not remove it again.

Related Issue

#738
https://github.com/orgs/jazzband/projects/1

Motivation and Context

This is only needed to keep Jazzband projects close in how they are configured.

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have run the make format command to format my code
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have added my name and/or github handle to AUTHORS.rst
  • I have added my change to CHANGES.rst
  • All new and existing tests passed.

Original text I've used in other PRs relating to the migration to GitHub Actions:

Travis CI has a new pricing model which places limits on open source.

Many projects are moving to GitHub Actions instead, including Jazzband projects:

This is based on jazzband/contextlib2#26.

TODO:

  • @jezdez to add JAZZBAND_RELEASE_KEY to the repo secrets.

@jezdez jezdez added this to In progress in Migrate to GitHub Actions via automation Dec 30, 2020
@jezdez jezdez moved this from In progress to In review in Migrate to GitHub Actions Dec 30, 2020
@codecov
Copy link

codecov bot commented Dec 30, 2020

Codecov Report

Merging #769 (c3ac048) into master (faed6d5) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #769   +/-   ##
=======================================
  Coverage   97.47%   97.47%           
=======================================
  Files          18       18           
  Lines         992      992           
  Branches      151      151           
=======================================
  Hits          967      967           
  Misses         12       12           
  Partials       13       13           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update faed6d5...c3ac048. Read the comment docs.

@ThePumpingLemma
Copy link
Collaborator

It appears that every build is running twice? Is that intentional?

@jezdez
Copy link
Member Author

jezdez commented Jan 2, 2021

@ThePumpingLemma Yeah, that's expected (even if a bit broad) since we're tracking both pushes to all branches (including the pull request branch) as well as other pull request events (by default "opened", "synchronize" and "reopened").

Those pull request events basically just describe other things that can happen to a pull request during its lifetime (and after its first lifetime for that matter) so that the tests are always run in whatever state the PR is in. The "synchronize" event type happens when a pull request's branch is updated with the tracking branch (e.g. the main/master branch is merged in). Hope that explains the reasoning.

Copy link
Collaborator

@ThePumpingLemma ThePumpingLemma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jezdez!

Migrate to GitHub Actions automation moved this from In review to Reviewed Jan 2, 2021
@ThePumpingLemma ThePumpingLemma merged commit 60beaf4 into master Jan 2, 2021
Migrate to GitHub Actions automation moved this from Reviewed to Done Jan 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants