Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow for running tests with break on error #890

Conversation

jeking3
Copy link
Contributor

@jeking3 jeking3 commented Sep 29, 2021

Description

This allows one to run tox -e py39-djmain-sqlite3 -- --pdb and have unit tests break on error into the debugger.

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have run the make format command to format my code
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have added my name and/or github handle to AUTHORS.rst
  • I have added my change to CHANGES.rst
  • All new and existing tests passed.

@jeking3 jeking3 force-pushed the jking/add-break-on-error-support-for-testing branch from 79b487d to b82011f Compare September 29, 2021 14:34
@jeking3 jeking3 requested a review from a team September 29, 2021 14:50
@codecov
Copy link

codecov bot commented Sep 29, 2021

Codecov Report

Merging #890 (843de03) into master (d8e5602) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #890   +/-   ##
=======================================
  Coverage   97.83%   97.83%           
=======================================
  Files          22       22           
  Lines        1062     1062           
  Branches      162      162           
=======================================
  Hits         1039     1039           
  Misses         10       10           
  Partials       13       13           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d8e5602...843de03. Read the comment docs.

@jeking3 jeking3 force-pushed the jking/add-break-on-error-support-for-testing branch from b82011f to 843de03 Compare October 25, 2021 19:55
@jeking3
Copy link
Contributor Author

jeking3 commented Oct 25, 2021

@jazzband/django-simple-history this is a small pull request that improves maintainability; would appreciate a review.

Copy link
Contributor

@tim-schilling tim-schilling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@jeking3 jeking3 merged commit 8215eb9 into jazzband:master Oct 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants